mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 68662: Avoided double copying of outgoing messages in the master.
Date Thu, 06 Sep 2018 22:39:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68662/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann.


Bugs: MESOS-9213
    https://issues.apache.org/jira/browse/MESOS-9213


Repository: mesos


Description
-------

When framework metrics were introduced, there was an evolve + devolve
conversion occuring in order to map old style messages to the new
`scheduler::Event::Type`. This results in copying all outgoing
messages twice.

This patch avoids the copying by adding overloads for the old style
messages.


Diffs
-----

  src/master/master.hpp ec2ae01ec813ff7fcb0e2a3d0dbad3c3f9993a98 
  src/master/metrics.hpp 14f894a40e96be93037e0d262ddc4b04a6fcc301 
  src/master/metrics.cpp 655c75a042a3bfeb264a55d7495f957c407a4d6d 


Diff: https://reviews.apache.org/r/68662/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message