mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 68731: Added a ScalarResourceQuantities type to improve sorter performance.
Date Mon, 17 Sep 2018 02:59:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68731/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Meng Zhu.


Bugs: MESOS-9239
    https://issues.apache.org/jira/browse/MESOS-9239


Repository: mesos


Description
-------

This type replaces the use of hashmaps keyed by resource names in
favor of storing vectors of `pair<string,Value::Scalar>`, in order
to avoid the performance penalty of using hashmaps.

Running *HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/21 shows
the following improvement:

Using 10000 agents and 1000 frameworks
Added 1000 frameworks in 42.49ms -> 42.85ms (no change)
Added 10000 agents in 7.69secs -> 4.89secs (normalized: 1 -> 0.64)
round 0 allocate() took 5.42secs -> 3.53secs (nomralized: 1 -> 0.65)


Diffs
-----

  src/master/allocator/sorter/drf/sorter.hpp 5a4fa5e2dca61168923261230b1f5c245354cbb7 


Diff: https://reviews.apache.org/r/68731/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message