mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68749: Fixed the CSI protobuf build dependencies.
Date Tue, 18 Sep 2018 20:14:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68749/#review208728
-----------------------------------------------------------


Fix it, then Ship it!





Makefile.am
Lines 55 (patched)
<https://reviews.apache.org/r/68749/#comment292877>

    `s/we don't have/we do not/`



src/Makefile.am
Lines 483 (patched)
<https://reviews.apache.org/r/68749/#comment292878>

    Can we use `$(MKDIR_P) $(@D)` for consistency and easier maintenance? The only difference
between this rule and e.g., the Java protobuf rules below seems to be that this one uses multiple
targets.



src/Makefile.am
Lines 487 (patched)
<https://reviews.apache.org/r/68749/#comment292879>

    Ditto.


- Benjamin Bannier


On Sept. 18, 2018, 7:39 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68749/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2018, 7:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-9240
>     https://issues.apache.org/jira/browse/MESOS-9240
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Generating the CSI protobufs depends on the `$(builddir)/include/csi`
> directory being created at configuration time. This only happens
> when automake build dependencies are enabled, however. In some
> distributions, rpmbuild will pass `--disable-dependency-tracking`,
> which will disable automake dependency tracking and prevent this
> directory being created. The fix is to simply ensure the CSI protobuf
> generation rules create the output directory is necessary.
> 
> 
> Diffs
> -----
> 
>   Makefile.am 25028a949b9a3420bf3a379d65bcbae8e028aeaa 
>   src/Makefile.am b0d63e2feef4bbbb186443ff9620a96473799a9f 
> 
> 
> Diff: https://reviews.apache.org/r/68749/diff/1/
> 
> 
> Testing
> -------
> 
> Verified that `./support/docker-build.sh` fails after updating `AM_DISTCHECK_CONFIGURE_FLAGS`
and then succeeds.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message