mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68759: Cleaned up the `ContainerDaemon` implementation.
Date Wed, 19 Sep 2018 13:38:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68759/#review208763
-----------------------------------------------------------




src/slave/container_daemon.hpp
Lines 86 (patched)
<https://reviews.apache.org/r/68759/#comment292916>

    Any reason we don't just use a `process::Promise` terminated here instead of sharing state?



src/slave/container_daemon.cpp
Line 262 (original), 263 (patched)
<https://reviews.apache.org/r/68759/#comment292917>

    That we don't `wait` for the wrapped process to terminate here seems significant. Could
you explain why that is okay?


- Benjamin Bannier


On Sept. 19, 2018, 6:51 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68759/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2018, 6:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9228
>     https://issues.apache.org/jira/browse/MESOS-9228
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch made the following changes to the container daemon:
> 1. Made it stores the launch parameters instead of an `agent::Call`.
> 2. Cleaned up the log messages.
> 3. Made the process managed by libprocess.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_daemon.hpp a58140dd787524b0438ba4719fa7e3365ab2fa17 
>   src/slave/container_daemon.cpp e1b0812b8b467ee4061b23d39552e2417d65a14a 
>   src/slave/container_daemon_process.hpp a5d19a04223f6f595e97ec83962558639fd51f7b 
> 
> 
> Diff: https://reviews.apache.org/r/68759/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message