mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68773: Added more logging to `DynamicReservationFramework`.
Date Thu, 20 Sep 2018 06:53:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68773/#review208792
-----------------------------------------------------------


Fix it, then Ship it!




I left some comments about the state logging, but I think if we want to add that we can just
do so in a separate patch and land the check logging more quickly in this patch.


src/examples/dynamic_reservation_framework.cpp
Lines 117 (patched)
<https://reviews.apache.org/r/68773/#comment292988>

    Do we need this and the log line at the end? Seems like if the CHECK fails we know which
state the agent was in?
    
    How about just logging the state changes?



src/examples/dynamic_reservation_framework.cpp
Lines 202 (patched)
<https://reviews.apache.org/r/68773/#comment292989>

    Ditto here, seems like we should just log the state changes instead of re-logging the
state each time?


- Benjamin Mahler


On Sept. 19, 2018, 11:02 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68773/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2018, 11:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5804
>     https://issues.apache.org/jira/browse/MESOS-5804
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would help to investigate MESOS-5804.
> 
> 
> Diffs
> -----
> 
>   src/examples/dynamic_reservation_framework.cpp 9c217254ddb1d873efe6cadfa1cc1249257396b3

> 
> 
> Diff: https://reviews.apache.org/r/68773/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message