mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68773: Added more logging to `DynamicReservationFramework`.
Date Thu, 20 Sep 2018 17:04:05 GMT


> On Sept. 19, 2018, 11:53 p.m., Benjamin Mahler wrote:
> > I left some comments about the state logging, but I think if we want to add that
we can just do so in a separate patch and land the check logging more quickly in this patch.

Yeah, removed them. I think the added logging should be already enough.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68773/#review208792
-----------------------------------------------------------


On Sept. 20, 2018, 10:03 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68773/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2018, 10:03 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5804
>     https://issues.apache.org/jira/browse/MESOS-5804
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would help to investigate MESOS-5804.
> 
> 
> Diffs
> -----
> 
>   src/examples/dynamic_reservation_framework.cpp 9c217254ddb1d873efe6cadfa1cc1249257396b3

> 
> 
> Diff: https://reviews.apache.org/r/68773/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message