mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.
Date Fri, 21 Sep 2018 23:24:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68731/
-----------------------------------------------------------

(Updated Sept. 21, 2018, 11:24 p.m.)


Review request for mesos, Gastón Kleiman and Meng Zhu.


Changes
-------

Updated per feedback.


Bugs: MESOS-9239
    https://issues.apache.org/jira/browse/MESOS-9239


Repository: mesos


Description
-------

This type replaces the use of hashmaps keyed by resource names in
favor of storing vectors of `pair<string,Value::Scalar>`, in order
to avoid the performance penalty of using hashmaps.

Running *HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/21 shows
the following improvement:

Using 10000 agents and 1000 frameworks
Added 1000 frameworks in 42.49ms -> 42.85ms (no change)
Added 10000 agents in 7.69secs -> 4.89secs (normalized: 1 -> 0.64)
round 0 allocate() took 5.42secs -> 3.53secs (nomralized: 1 -> 0.65)


Diffs (updated)
-----

  src/master/allocator/sorter/drf/sorter.hpp 71352c848e812b7c499dfbf0f09dc86fac3ee8e1 
  src/master/allocator/sorter/random/sorter.hpp 6bfeda0f0d02b4738a6d46a7798b1bf4751f0b38 
  src/master/allocator/sorter/sorter.hpp 432ccfe24ed2854df9cc186a8691009cbdb763c7 


Diff: https://reviews.apache.org/r/68731/diff/3/

Changes: https://reviews.apache.org/r/68731/diff/2-3/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message