mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 68808: Avoided dirtying the DRF sorter when an allocation is performed.
Date Tue, 25 Sep 2018 02:23:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68808/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Meng Zhu.


Bugs: MESOS-9249
    https://issues.apache.org/jira/browse/MESOS-9249


Repository: mesos


Description
-------

This improves performance by ensuring that the DRF sorter can remain
sorted throughout an allocation cycle. Without this change, we spend
the majority of time re-sorting throughout an allocation cycle, when
there are large numbers of clients (roles / frameworks).

Before with --enable-optimize:

*HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/21
Added 1000 frameworks in 28.685387ms
Added 10000 agents in 3.962511243secs
round 0 allocate() took 3.183115931secs to make 10000 offers ...
round 1 allocate() took 3.398068093secs to make 10000 offers ...
round 2 allocate() took 3.314738469secs to make 10000 offers ...

After with --enable-optimize:

*HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/21
Added 1000 frameworks in 38.145091ms
Added 10000 agents in 1.791872685secs
round 0 allocate() took 1.193577545secs to make 10000 offers ...
round 1 allocate() took 1.288540671secs to make 10000 offers ...
round 2 allocate() took 1.169376468secs to make 10000 offers ...


Diffs
-----

  src/master/allocator/sorter/drf/sorter.cpp a45f66ff0d77becb6f96f7ff4c288e4ab218e070 


Diff: https://reviews.apache.org/r/68808/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message