From reviews-return-81733-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Sep 2 05:33:22 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C6628186FD for ; Sun, 2 Sep 2018 05:33:22 +0000 (UTC) Received: (qmail 48492 invoked by uid 500); 2 Sep 2018 05:33:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 48457 invoked by uid 500); 2 Sep 2018 05:33:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 48446 invoked by uid 99); 2 Sep 2018 05:33:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Sep 2018 05:33:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8D940C6865; Sun, 2 Sep 2018 05:33:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.65 X-Spam-Level: ** X-Spam-Status: No, score=2.65 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wKaxpNEkFHsg; Sun, 2 Sep 2018 05:33:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E696E5F117; Sun, 2 Sep 2018 05:33:19 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4126DE0111; Sun, 2 Sep 2018 05:33:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 19A6BC40067; Sun, 2 Sep 2018 05:33:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7074317505443529247==" MIME-Version: 1.0 Subject: Re: Review Request 68066: Shared GC actor between Agent and MesosContainerizer. From: Qian Zhang To: Qian Zhang Cc: Joseph Wu , mesos Date: Sun, 02 Sep 2018 05:33:19 -0000 Message-ID: <20180902053319.50525.6197@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68066/ X-Sender: Qian Zhang X-ReviewBoard-ShipIt: 1 References: <20180822183312.5559.55968@reviews-vm2.apache.org> In-Reply-To: <20180822183312.5559.55968@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============7074317505443529247== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68066/#review208235 ----------------------------------------------------------- Ship it! Ship It! - Qian Zhang On Aug. 23, 2018, 2:33 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68066/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2018, 2:33 a.m.) > > > Review request for mesos, Gilbert Song and Qian Zhang. > > > Bugs: MESOS-7947 > https://issues.apache.org/jira/browse/MESOS-7947 > > > Repository: mesos > > > Description > ------- > > This inserts the pointer to the GC actor into the MesosContainerizer, > so the containerizer can schedule sandboxes it manages for GC according > to the agent's GC policy. The Composing/Docker Containerizers are > unchanged as they do not directly deal with nested or standalone > containers. > > To minimize test changes, the GC actor argument defaults to nullptr. > Only tests that exercise sandbox GC will need to supply the actor. > > > Diffs > ----- > > src/local/local.cpp 5b7bb59576cfc7c0c7b5e438fee1d2703c7fad2f > src/slave/containerizer/containerizer.hpp 675dfade265fe9fdd0e8649e918f5ff4e370629f > src/slave/containerizer/containerizer.cpp 59f107af1c08877dedd0597d0f60123940927ab0 > src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b > src/slave/containerizer/mesos/containerizer.cpp c38bfacef6a0c8e3b8703c64b40d6d428c9013fe > src/slave/main.cpp 55615e75b37210e86a530cac0f9c5745262da55b > src/tests/cluster.cpp cb7d3f0298dfa8c11634d6674f93f2f355b48a53 > src/tests/containerizer/cni_isolator_tests.cpp 63b109bdbc23733aa3d4cdce1de5385ad9933be8 > src/tests/containerizer/docker_volume_isolator_tests.cpp 553f34429fb4defd658c24767b00fe7c91ab3500 > src/tests/containerizer/environment_secret_isolator_tests.cpp 7a516e5da7053971e0d7dbac29cdfc34eb04bfd5 > src/tests/containerizer/mesos_containerizer_tests.cpp 1b8e53ca1bcd454a3e80c010181c0fddd8825b7e > src/tests/containerizer/volume_secret_isolator_tests.cpp 8b11c6f789c60e4d3ceda164f1523e9791123450 > > > Diff: https://reviews.apache.org/r/68066/diff/4/ > > > Testing > ------- > > See last patch in chain. > > > Thanks, > > Joseph Wu > > --===============7074317505443529247==--