| Gastón Kleiman |
Re: Review Request 69307: Changed master to hold subscribers in a circular buffer. |
Fri, 30 Nov, 20:43 |
| Alexander Rojas |
Re: Review Request 69368: Added test reproducing crash on authorization failure. |
Fri, 16 Nov, 08:33 |
| Alexander Rojas |
Re: Review Request 69369: Added collectAuthorizations helper to master.hpp. |
Fri, 16 Nov, 08:35 |
| Alexander Rojas |
Review Request 69412: Fixed thread safety issue in jwt signature validation. |
Tue, 20 Nov, 14:51 |
| Alexander Rojas |
Re: Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization. |
Wed, 21 Nov, 07:40 |
| Alexander Rukletsov |
Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`. |
Thu, 01 Nov, 06:38 |
| Alexander Rukletsov |
Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. |
Sun, 04 Nov, 04:31 |
| Alexander Rukletsov |
Re: Review Request 69267: Fixed flaky SchedulerTest.MasterFailover. |
Thu, 08 Nov, 01:05 |
| Alexander Rukletsov |
Re: Review Request 69368: Added test reproducing crash on authorization failure. |
Sun, 18 Nov, 01:33 |
| Alexander Rukletsov |
Re: Review Request 69369: Added collectAuthorizations helper to master.hpp. |
Sun, 18 Nov, 01:49 |
| Alexander Rukletsov |
Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. |
Sun, 18 Nov, 04:49 |
| Alexander Rukletsov |
Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. |
Sun, 18 Nov, 20:10 |
| Alexander Rukletsov |
Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. |
Sun, 18 Nov, 20:13 |
| Alexander Rukletsov |
Re: Review Request 69384: Introduced common/authorization and refactored collectAuthorizations. |
Mon, 19 Nov, 09:36 |
| Alexander Rukletsov |
Re: Review Request 69385: Refactored createSubject and authorizeLogAccess to common/authorization. |
Mon, 19 Nov, 09:36 |
| Alexander Rukletsov |
Re: Review Request 69386: Added test for ACCESS_MESOS_LOG authorization. |
Mon, 19 Nov, 11:03 |
| Alexander Rukletsov |
Re: Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization. |
Tue, 20 Nov, 16:51 |
| Alexander Rukletsov |
Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks. |
Wed, 28 Nov, 14:35 |
| Alexander Rukletsov |
Re: Review Request 69464: Made the `createTask` helper work for both v0 and v1 API. |
Wed, 28 Nov, 14:38 |
| Andrei Budnik |
Re: Review Request 68016: Added libseccomp to the build. |
Thu, 08 Nov, 15:23 |
| Andrei Budnik |
Re: Review Request 68017: Added Seccomp-related protobuf messages. |
Thu, 08 Nov, 15:24 |
| Andrei Budnik |
Re: Review Request 68018: Added `SeccompFilter` class. |
Thu, 08 Nov, 15:24 |
| Andrei Budnik |
Re: Review Request 68019: Added a parser for the Docker Seccomp config format. |
Thu, 08 Nov, 15:24 |
| Andrei Budnik |
Re: Review Request 68020: Added Seccomp-related flags to the agent. |
Thu, 08 Nov, 15:24 |
| Andrei Budnik |
Re: Review Request 68021: Added `linux/seccomp` isolator. |
Thu, 08 Nov, 15:24 |
| Andrei Budnik |
Re: Review Request 68017: Added Seccomp-related protobuf messages. |
Thu, 08 Nov, 15:27 |
| Andrei Budnik |
Review Request 69409: Added Seccomp parser tests. |
Tue, 20 Nov, 12:21 |
| Andrei Budnik |
Review Request 69420: Added Seccomp isolator tests. |
Wed, 21 Nov, 18:46 |
| Andrei Budnik |
Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor. |
Fri, 23 Nov, 13:44 |
| Andrei Budnik |
Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor. |
Mon, 26 Nov, 17:20 |
| Andrei Budnik |
Re: Review Request 69420: Added Seccomp isolator tests. |
Wed, 28 Nov, 11:47 |
| Andrei Budnik |
Review Request 69493: Documented the `linux/seccomp` isolator. |
Fri, 30 Nov, 16:33 |
| Armand Grillet |
Review Request 69237: Simplified 'test_exec' in new CLI to better manage newlines. |
Thu, 01 Nov, 22:28 |
| Armand Grillet |
Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. |
Mon, 05 Nov, 18:13 |
| Armand Grillet |
Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. |
Mon, 05 Nov, 22:22 |
| Armand Grillet |
Re: Review Request 69275: Added environment sanity check to parallel test runner. |
Wed, 07 Nov, 21:15 |
| Armand Grillet |
Re: Review Request 69274: Reduced default oversubscription in parallel test runner. |
Wed, 07 Nov, 21:16 |
| Armand Grillet |
Re: Review Request 69275: Added environment sanity check to parallel test runner. |
Wed, 07 Nov, 21:42 |
| Armand Grillet |
Re: Review Request 69309: Explicitly constructed command line args in parallel runner. |
Mon, 12 Nov, 10:10 |
| Armand Grillet |
Re: Review Request 69310: Always used absolute executable paths in parallel runner. |
Mon, 12 Nov, 10:25 |
| Armand Grillet |
Review Request 69374: Updated new CLI test step to use binary created by PyInstaller. |
Fri, 16 Nov, 21:36 |
| Armand Grillet |
Review Request 69380: Added configuration docs describing how to use Python 3. |
Sun, 18 Nov, 17:58 |
| Armand Grillet |
Review Request 69381: Updated configuration docs describing how to build the new CLI. |
Sun, 18 Nov, 17:58 |
| Armand Grillet |
Review Request 69390: Added docs describing how to use the new CLI. |
Mon, 19 Nov, 10:31 |
| Armand Grillet |
Review Request 69393: Displayed 'State' field when using 'mesos task list'. |
Mon, 19 Nov, 14:11 |
| Armand Grillet |
Review Request 69394: Updated 'mesos task list' to only display running tasks. |
Mon, 19 Nov, 14:17 |
| Armand Grillet |
Review Request 69395: Added '--all' flag to 'mesos task list'. |
Mon, 19 Nov, 14:17 |
| Armand Grillet |
Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'. |
Mon, 19 Nov, 16:14 |
| Armand Grillet |
Re: Review Request 69390: Added docs describing how to use the new CLI. |
Tue, 20 Nov, 10:57 |
| Armand Grillet |
Re: Review Request 69390: Added docs describing how to use the new CLI. |
Tue, 20 Nov, 11:12 |
| Armand Grillet |
Review Request 69425: Fixed name of task created when running mesos-cli-tests. |
Thu, 22 Nov, 11:33 |
| Armand Grillet |
Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'. |
Thu, 22 Nov, 11:35 |
| Armand Grillet |
Re: Review Request 69395: Added '--all' flag to 'mesos task list'. |
Thu, 22 Nov, 11:36 |
| Armand Grillet |
Re: Review Request 69395: Added '--all' flag to 'mesos task list'. |
Thu, 22 Nov, 11:36 |
| Armand Grillet |
Review Request 69442: Updated 'REPOSITORY_URL' in 'support/reviewboardrc' to use gitbox. |
Sat, 24 Nov, 13:13 |
| Armand Grillet |
Re: Review Request 69394: Updated 'mesos task list' to only display running tasks. |
Sun, 25 Nov, 09:53 |
| Armand Grillet |
Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'. |
Sun, 25 Nov, 11:08 |
| Armand Grillet |
Re: Review Request 69395: Added '--all' flag to 'mesos task list'. |
Sun, 25 Nov, 11:17 |
| Armand Grillet |
Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'. |
Mon, 26 Nov, 13:45 |
| Armand Grillet |
Re: Review Request 69395: Added '--all' flag to 'mesos task list'. |
Mon, 26 Nov, 13:51 |
| Armand Grillet |
Re: Review Request 69395: Added '--all' flag to 'mesos task list'. |
Mon, 26 Nov, 13:54 |
| Benjamin Bannier |
Review Request 69242: Saved some disk space in mesos-tidy Docker image. |
Fri, 02 Nov, 20:50 |
| Benjamin Bannier |
Review Request 69243: Used a `switch` statement to match enum values. |
Fri, 02 Nov, 20:51 |
| Benjamin Bannier |
Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. |
Mon, 05 Nov, 20:48 |
| Benjamin Bannier |
Re: Review Request 67958: Added LibprocessTest for easily configuring the library for a test. |
Tue, 06 Nov, 06:07 |
| Benjamin Bannier |
Review Request 69274: Reduced default oversubscription in parallel test runner. |
Wed, 07 Nov, 20:30 |
| Benjamin Bannier |
Review Request 69275: Added environment sanity check to parallel test runner. |
Wed, 07 Nov, 20:30 |
| Benjamin Bannier |
Review Request 69278: Added hierchical allocator benchmarks to the cmake build. |
Wed, 07 Nov, 21:17 |
| Benjamin Bannier |
Re: Review Request 69277: Updated autotools build to use parallel test runner by default. |
Wed, 07 Nov, 21:30 |
| Benjamin Bannier |
Re: Review Request 69275: Added environment sanity check to parallel test runner. |
Wed, 07 Nov, 21:41 |
| Benjamin Bannier |
Re: Review Request 69280: Fixed flakiness in `PartitionTest.TaskCompletedOnPartitionedAgent`. |
Wed, 07 Nov, 22:03 |
| Benjamin Bannier |
Review Request 69293: Disabled parallel test execution for reviewbot. |
Wed, 07 Nov, 22:57 |
| Benjamin Bannier |
Re: Review Request 69301: Fixed the ulimit validation in the parallel test runner. |
Fri, 09 Nov, 10:43 |
| Benjamin Bannier |
Review Request 69306: Fixed parallel test runner ulimit check for setups without limits. |
Fri, 09 Nov, 21:25 |
| Benjamin Bannier |
Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits. |
Fri, 09 Nov, 21:53 |
| Benjamin Bannier |
Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits. |
Fri, 09 Nov, 22:34 |
| Benjamin Bannier |
Review Request 69309: Explicitly constructed command line args in parallel runner. |
Sun, 11 Nov, 00:01 |
| Benjamin Bannier |
Review Request 69310: Always used absolute executable paths in parallel runner. |
Sun, 11 Nov, 00:01 |
| Benjamin Bannier |
Review Request 69311: Enabled parallel test runner to cmake build. |
Sun, 11 Nov, 00:01 |
| Benjamin Bannier |
Review Request 69312: Enabled parallel test runner to cmake build. |
Sun, 11 Nov, 00:01 |
| Benjamin Bannier |
Review Request 69313: Enabled parallel test runner to cmake build. |
Sun, 11 Nov, 00:01 |
| Benjamin Bannier |
Re: Review Request 69161: Renamed a function argument to not reuse member name. |
Mon, 12 Nov, 08:57 |
| Benjamin Bannier |
Re: Review Request 69161: Renamed a function argument to not reuse member name. |
Mon, 12 Nov, 08:57 |
| Benjamin Bannier |
Re: Review Request 69309: Explicitly constructed command line args in parallel runner. |
Mon, 12 Nov, 12:39 |
| Benjamin Bannier |
Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates. |
Mon, 12 Nov, 20:49 |
| Benjamin Bannier |
Re: Review Request 69162: Added agent and resource provider IDs to operation status messages. |
Mon, 12 Nov, 20:49 |
| Benjamin Bannier |
Re: Review Request 69327: Added whitespace in libprocess README. |
Tue, 13 Nov, 13:09 |
| Benjamin Bannier |
Re: Review Request 69157: Fixed handling for offer operation updates. |
Tue, 13 Nov, 21:10 |
| Benjamin Bannier |
Re: Review Request 69311: Enabled parallel test runner to cmake build. |
Wed, 14 Nov, 13:11 |
| Benjamin Bannier |
Re: Review Request 69311: Enabled parallel test runner to cmake build. |
Wed, 14 Nov, 13:11 |
| Benjamin Bannier |
Review Request 69338: Change agent to not report disconnected resource providers. |
Wed, 14 Nov, 14:36 |
| Benjamin Bannier |
Review Request 69337: Garbage collected disappeared resource providers from master state. |
Wed, 14 Nov, 14:36 |
| Benjamin Bannier |
Re: Review Request 69366: Used `OperationID` instead of `string` in test helpers. |
Fri, 16 Nov, 08:32 |
| Benjamin Bannier |
Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`. |
Fri, 16 Nov, 12:01 |
| Benjamin Bannier |
Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`. |
Fri, 16 Nov, 12:01 |
| Benjamin Bannier |
Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`. |
Fri, 16 Nov, 12:02 |
| Benjamin Bannier |
Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`. |
Fri, 16 Nov, 12:02 |
| Benjamin Bannier |
Re: Review Request 69363: Cleaned up `include/mesos/type_utils.hpp`. |
Fri, 16 Nov, 15:28 |
| Benjamin Bannier |
Review Request 69397: Used high-level `FrameworkInfo` validation function in tests. |
Mon, 19 Nov, 15:52 |
| Benjamin Bannier |
Review Request 69398: Added validation for `FrameworkID`s. |
Mon, 19 Nov, 15:52 |