mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James DeFelice <james.defel...@gmail.com>
Subject Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.
Date Wed, 05 Dec 2018 14:38:09 GMT


> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote:
> > include/mesos/v1/mesos.proto
> > Lines 2434 (patched)
> > <https://reviews.apache.org/r/69162/diff/7/?file=2111243#file2111243line2434>
> >
> >     I'd like this part to be a bit more fleshed out:
> >     
> >     When `uuid` is set then it MUST be possible to acknowledge the status update
by using the specified `agent_id` and `resource_provider_id` (for local providers); and `resource_provider_id`
(for external providers).
> 
> Benjamin Bannier wrote:
>     I'd argue that this is already implied by the documentation of `uuid`,
>     ````
>     // Statuses that are delivered reliably to the scheduler will
>     // include a `uuid`. The status is considered delivered once
>     // it is acknowledged by the scheduler.
>     optional UUID uuid = 5;
>     ````
>     
>     Dropping for now.

I see what you mean by it being implied. However, I'd really like for it to be more explicitly
documented so that it's not accidentally overlooked later.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69162/#review211030
-----------------------------------------------------------


On Dec. 5, 2018, noon, Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69162/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2018, noon)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.
> 
> 
> Bugs: MESOS-9293
>     https://issues.apache.org/jira/browse/MESOS-9293
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds agent and resource provider IDs to
> `UpdateOperationStatus` and `UpdateOperationStatusMessage`. With that
> frameworks are able to reconcile enough information after failover to
> construct operation acknowledgements.
> 
> We will add code to populate these fields in a follow-up patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto c822cc747cf153435b6c3ae1004168d5a289c97b 
>   include/mesos/v1/mesos.proto 51c1bfdbb360b3554eba2229ed386d6271e0315b 
>   src/common/type_utils.cpp ef13eae47b88efc15f1b2d00852b6387c2fffcbc 
>   src/internal/devolve.cpp 491ed2aa131a92e958bfa71cccfc5f257cd4b3f9 
>   src/internal/evolve.cpp aa60efed5a28ed4d847a4a27aa8e994cda82175d 
> 
> 
> Diff: https://reviews.apache.org/r/69162/diff/8/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message