mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68138: Added tests to ensure correct quota accounting.
Date Wed, 05 Dec 2018 17:03:28 GMT


> On Dec. 4, 2018, 12:51 p.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 1702 (patched)
> > <https://reviews.apache.org/r/68138/diff/2/?file=2091014#file2091014line1702>
> >
> >     Maybe: QuotaAccountingReserveAllocatedResources?

Sounds good.


> On Dec. 4, 2018, 12:51 p.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 1751-1761 (patched)
> > <https://reviews.apache.org/r/68138/diff/2/?file=2091014#file2091014line1751>
> >
> >     The way this test is written only catches the case where making the reservation
could double-charge the quota, but it doesn't catch a bug where the reservation would lead
to no-charge of the quota. One way to resolve this easily is to make the second agent larger,
in order to make sure that the allocation is getting chopped to match the unsatisfied quota
exactly.

We already have tests to ensure reservations are charged towards the quota. But yeah, does
not hurt to double verify it here.


> On Dec. 4, 2018, 12:51 p.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 1767 (patched)
> > <https://reviews.apache.org/r/68138/diff/2/?file=2091014#file2091014line1767>
> >
> >     Maybe: QuotaAccountingUnreserveAllocatedResources?

Sounds good.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68138/#review211024
-----------------------------------------------------------


On Dec. 5, 2018, 9:03 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68138/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2018, 9:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9099
>     https://issues.apache.org/jira/browse/MESOS-9099
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added two allocator tests to ensure reserving and
> unreserving allocated resources do not affect
> quota accounting.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 3034d460dd48b5134cfd4a24c54775222a348e32

> 
> 
> Diff: https://reviews.apache.org/r/68138/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message