mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69474: Added tests for agent/executor heartbeating.
Date Thu, 06 Dec 2018 00:52:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69474/#review211056
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/executor_http_api_tests.cpp
Lines 31-32 (patched)
<https://reviews.apache.org/r/69474/#comment295943>

    These can be removed.



src/tests/executor_http_api_tests.cpp
Lines 973-974 (patched)
<https://reviews.apache.org/r/69474/#comment295915>

    Newline between these lines?



src/tests/executor_http_api_tests.cpp
Lines 1121 (patched)
<https://reviews.apache.org/r/69474/#comment295937>

    s/heartbeats are/heartbeats are sent/



src/tests/executor_http_api_tests.cpp
Lines 1171 (patched)
<https://reviews.apache.org/r/69474/#comment295939>

    s/Calls/calls/ for consistency with "events".



src/tests/executor_http_api_tests.cpp
Lines 1226 (patched)
<https://reviews.apache.org/r/69474/#comment295942>

    If we don't break this value out into a header now, let's leave a TODO here to update
later.


- Greg Mann


On Nov. 30, 2018, 12:03 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69474/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2018, 12:03 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-7564
>     https://issues.apache.org/jira/browse/MESOS-7564
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds two separate tests which check if the Agent sends heartbeats
> to HTTP executors, and if the HTTP executor driver sends heartbeats
> to the agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/executor_http_api_tests.cpp a635e1a3c228b52f47ba81a67753ea49ce092143 
> 
> 
> Diff: https://reviews.apache.org/r/69474/diff/3/
> 
> 
> Testing
> -------
> 
> ```
> cmake --build . --target check
> src/mesos-tests --gtest_filter="*Heartbeat*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message