mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Chung <cinchu...@gmail.com>
Subject Re: Review Request 67185: Added request_protobuf to mesos.http.
Date Thu, 06 Dec 2018 01:28:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67185/
-----------------------------------------------------------

(Updated Dec. 6, 2018, 1:28 a.m.)


Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao Li.


Repository: mesos


Description
-------

This change adds the method `Resource.request_protobuf()` which assumes
that both the request and response data are encoded in protobuf. This
will be used later in the RPC client, which will also include a decoding
step.

Testing Done:
Ran unit tests with `tox` under `src/python/lib`


Diffs (updated)
-----

  src/python/lib/mesos/constants.py PRE-CREATION 
  src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd 
  src/python/lib/requirements.in 86ee2ad40c0c114b0082f2d4f52f75758d41cbd9 
  src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 


Diff: https://reviews.apache.org/r/67185/diff/5/

Changes: https://reviews.apache.org/r/67185/diff/4-5/


Testing
-------


Thanks,

Eric Chung


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message