mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 69516: Fixed a flaky test EndpointCreateThenOfferRemove.
Date Thu, 06 Dec 2018 23:54:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69516/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Gastón Kleiman.


Bugs: MESOS-7971
    https://issues.apache.org/jira/browse/MESOS-7971


Repository: mesos


Description
-------

The test is flaky due to the race between agent processing
operations and master sending out offers.

The test expects the offer to be sent out after the reserve
and create operations have finished. But it only waits for
the 202 returned by both calls.

This patch adds manual clock control and uses `Clock::settle()`
to ensure calls are processed before proceeding.


Diffs
-----

  src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7



Diff: https://reviews.apache.org/r/69516/diff/1/


Testing
-------

make check
ran continuously without failing


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message