mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69337: Garbage collected disappeared resource providers from master state.
Date Fri, 07 Dec 2018 02:18:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69337/#review211104
-----------------------------------------------------------




src/master/master.cpp
Lines 8227 (patched)
<https://reviews.apache.org/r/69337/#comment296031>

    Should this be called "garbage collection" or just "removal"?



src/master/master.cpp
Lines 8228 (patched)
<https://reviews.apache.org/r/69337/#comment296032>

    It seems to me that we should remove the disappeared resources even if there is no resource
provider reported, otherwise if the operator manually deleted the resource provider configs,
we will see the stale resources forever.



src/master/master.cpp
Lines 8260 (patched)
<https://reviews.apache.org/r/69337/#comment296033>

    Can you explain why we need to use this `resourceProvider` temporary variable here, given
that `total_resources` is empty?



src/master/master.cpp
Lines 8262 (patched)
<https://reviews.apache.org/r/69337/#comment296034>

    Not sure if we have discussed about this before. What's the pros and cons of totally erasing
the resource provider, versus just removing its resources and operations?


- Chun-Hung Hsiao


On Nov. 14, 2018, 2:36 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69337/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2018, 2:36 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-9384
>     https://issues.apache.org/jira/browse/MESOS-9384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master previously kept information on resource providers
> indefinitely. This was confusing to API users who saw resource
> providers reported which where not present anymore, and also made it
> harder to derive actual cluster state.
> 
> With this patch we remove resource providers not reported by the agent
> from master state. We still need to update the agent to not report
> removed resource providers in a follow-up patch.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
> 
> 
> Diff: https://reviews.apache.org/r/69337/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message