mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.
Date Fri, 07 Dec 2018 04:31:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69037/
-----------------------------------------------------------

(Updated Dec. 7, 2018, 4:31 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.


Changes
-------

Updated the descriptions and implemented resource comparison and printing logic.


Summary (updated)
-----------------

Added an optional `vendor` field to `Resource.DiskInfo.Source`.


Bugs: MESOS-9321
    https://issues.apache.org/jira/browse/MESOS-9321


Repository: mesos


Description (updated)
-------

The new `vendor` field together with the `id` field provide the means of
uniquely identifying a CSI volume upon a CSI plugin migration (e.g.,
there is a change in the agent ID).


Diffs (updated)
-----

  include/mesos/mesos.proto 56107f47a46ac3679a57af0580c55ad0f98543f5 
  include/mesos/v1/mesos.proto c6e7515a44eca0b057725c7b8196250072b56be5 
  src/common/resources.cpp 1585e30ae9b8ba14b67deed33d67fa2d88576caa 
  src/v1/resources.cpp 0248f1da650b4973d09eaab3cfbe5a113b5a447a 


Diff: https://reviews.apache.org/r/69037/diff/2/

Changes: https://reviews.apache.org/r/69037/diff/1-2/


Testing (updated)
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message