mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaysoky commented on issue #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes
Date Wed, 16 Jan 2019 17:52:21 GMT
kaysoky commented on issue #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication
schemes
URL: https://github.com/apache/mesos/pull/324#issuecomment-454875262
 
 
   Yes, a unit test for this URL parsing would be good, if that is the approach we end up
with.
   
   In terms of how the tests are set up:
    - The gtest class `ZooKeeperTest` instantiates a `ZooKeeperTestServer` in its constructor:
https://github.com/apache/mesos/blob/master/src/tests/zookeeper.hpp#L119
    - This object is defined here: https://github.com/apache/mesos/blob/master/src/tests/zookeeper_test_server.hpp#L36
    - This wrapper class instantiates a ZK server using the C API provided by ZK: https://github.com/apache/mesos/blob/master/src/tests/zookeeper_test_server.cpp#L57-L59

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message