mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68017: Added Seccomp-related protobuf messages.
Date Wed, 02 Jan 2019 20:23:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68017/#review211613
-----------------------------------------------------------




include/mesos/slave/containerizer.proto
Line 26 (original), 26 (patched)
<https://reviews.apache.org/r/68017/#comment296968>

    See my comment below, and just add:
    
    ```
    import "mesos/seccomp/seccomp.proto`;
    ```



include/mesos/slave/containerizer.proto
Lines 197 (patched)
<https://reviews.apache.org/r/68017/#comment296967>

    As we discussed last time, could we move this protobuf message to `include/mesos/seccomp/`
dir, since this is not user facing API in the future, nor container life cycle managerment
(in containerizer.proto).


- Gilbert Song


On Nov. 8, 2018, 7:24 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68017/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2018, 7:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
> 
> 
> Bugs: MESOS-9033
>     https://issues.apache.org/jira/browse/MESOS-9033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d 
>   include/mesos/slave/containerizer.proto 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 
>   include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb 
> 
> 
> Diff: https://reviews.apache.org/r/68017/diff/11/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message