mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 69612: Refactored parallel test runner.
Date Wed, 16 Jan 2019 14:56:19 GMT


> On Jan. 16, 2019, 2:02 p.m., Benjamin Bannier wrote:
> > support/mesos-gtest-runner.py
> > Line 246 (original)
> > <https://reviews.apache.org/r/69612/diff/1/?file=2115315#file2115315line247>
> >
> >     Any reason to not preserve the path normalization here?

`EXECUTABLE` class variable is initialized with `abspath` and passed to `options_gen` as an
argument.
I think it's the caller's duty to ensure that the path is absolute.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69612/#review212068
-----------------------------------------------------------


On Dec. 20, 2018, 4:40 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69612/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050 
> 
> 
> Diff: https://reviews.apache.org/r/69612/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> sudo make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message