mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69775: Updated master fail() logging from FATAL to ERROR.
Date Wed, 16 Jan 2019 22:45:47 GMT


> On Jan. 16, 2019, 9:39 p.m., Vinod Kone wrote:
> > src/master/master.cpp
> > Line 1627 (original), 1627 (patched)
> > <https://reviews.apache.org/r/69775/diff/1/?file=2120094#file2120094line1627>
> >
> >     This exited the process before, now we no longer do? Is that safe?

We could do:
```
LOG(ERROR) << message << ": " << failure;
EXIT(EXIT_FAILURE);
```


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69775/#review212082
-----------------------------------------------------------


On Jan. 16, 2019, 9:17 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69775/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2019, 9:17 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Greg Mann, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> LOG(FATAL) would dump a stack trace which may confuse people with
> a master crash case. We should just print out an error msg.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 9624832d017dae717da803ca2ff2f8fc5135ea9d 
> 
> 
> Diff: https://reviews.apache.org/r/69775/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message