mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 69775: Updated master fail() logging from FATAL to ERROR.
Date Wed, 16 Jan 2019 23:07:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69775/
-----------------------------------------------------------

(Updated Jan. 16, 2019, 3:07 p.m.)


Review request for mesos, Andrei Budnik, Benjamin Mahler, Greg Mann, and Qian Zhang.


Repository: mesos


Description
-------

LOG(FATAL) would dump a stack trace which may confuse people with
a master crash case. We should just print out an error msg.


Diffs (updated)
-----

  src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2 


Diff: https://reviews.apache.org/r/69775/diff/2/

Changes: https://reviews.apache.org/r/69775/diff/1-2/


Testing
-------

N/A


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message