mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 69776: Fixed flakiness by adding per agent config dir for mesos test.
Date Thu, 17 Jan 2019 00:45:15 GMT


> On Jan. 16, 2019, 10:10 p.m., Jie Yu wrote:
> > src/tests/mesos.cpp
> > Line 173 (original), 173 (patched)
> > <https://reviews.apache.org/r/69776/diff/1/?file=2120114#file2120114line173>
> >
> >     s/agentDir/configDir/
> 
> Gilbert Song wrote:
>     I thought about `configDir`, sounds not appropriate to me, since store dir, fetcher
dir are not config specific. While we are putting everything together, agentDir is the only
name I can think of.

ok, sure!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69776/#review212083
-----------------------------------------------------------


On Jan. 16, 2019, 10:08 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69776/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2019, 10:08 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Greg Mann, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In mesos tests, there are some cases that multiple agents are
> running simultanuously. From commit 07bccc63, we start to have
> agents share the same config dir in the test sandbox. Unit
> tests that use the same credicial file dir may fail if there
> are agents read and write to the same credential file
> simultanuously. We should set unique dir per agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.cpp 0d51687f2fc05804d2668837f0cbec4bc2b2e35a 
> 
> 
> Diff: https://reviews.apache.org/r/69776/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message