mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69723: Enabled operation feedback on agent default resources.
Date Fri, 18 Jan 2019 01:51:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69723/#review212119
-----------------------------------------------------------



This patch LGTM, modulo the note below regarding the extra capability check, once we have
that in place. Thanks Benno!!


src/master/master.cpp
Lines 4367-4374 (original), 4359-4366 (patched)
<https://reviews.apache.org/r/69723/#comment297731>

    As we discussed elsewhere, we need to perform a similar check for the case where `(!slave->capabilities.agentOperationFeedback
&& !operation.has_resource_provider_id())` once we have the new capability in place.



src/tests/api_tests.cpp
Lines 5260 (patched)
<https://reviews.apache.org/r/69723/#comment297732>

    s/that the we/that schedulers/


- Greg Mann


On Jan. 16, 2019, 3:54 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69723/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-9472
>     https://issues.apache.org/jira/browse/MESOS-9472
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Up to now, the master would validate that any operation
> requesting operation feedback would only act on resources
> belonging to a resource provider.
> 
> This patch removes this restriction and enables frameworks
> to request operation feedback on an agent's default
> resources.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2 
>   src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741 
>   src/slave/slave.cpp 10cbc190acc7eea5734efa0066541168545a66b6 
>   src/tests/api_tests.cpp 79a2d2966ff6533629aeeefaaaf19e849b76e0e6 
>   src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28 
>   src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550 
> 
> 
> Diff: https://reviews.apache.org/r/69723/diff/2/
> 
> 
> Testing
> -------
> 
> ./src/mesos-tests
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message