mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69158: Added an integration test for resource provider removal.
Date Fri, 18 Jan 2019 04:18:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69158/#review212124
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 10721 (patched)
<https://reviews.apache.org/r/69158/#comment297744>

    This is not necessary.



src/tests/slave_tests.cpp
Lines 10792-10794 (patched)
<https://reviews.apache.org/r/69158/#comment297747>

    Nit: indent by extra 2 spaces. I'd suggest that we don't break the line after `if (`,
or break it after the first &&:
    ```
    if (resource.has_provider_id() &&
        resource.has_disk() &&
        ...) {
      rawDisk = resources;
      break;
    }
    ```
    So the condition and body are distinguishable.



src/tests/slave_tests.cpp
Lines 10802 (patched)
<https://reviews.apache.org/r/69158/#comment297748>

    The term "inject" make me think that this operation is injected through an internal mechanism.
How about just say "Create a pending operation."?



src/tests/slave_tests.cpp
Lines 10863 (patched)
<https://reviews.apache.org/r/69158/#comment297742>

    an operation



src/tests/slave_tests.cpp
Lines 10880 (patched)
<https://reviews.apache.org/r/69158/#comment297749>

    there is no resource managed


- Chun-Hung Hsiao


On Jan. 17, 2019, 11:17 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69158/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2019, 11:17 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an integration test for resource provider removal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69158/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message