mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69781: Fixed flakiness of resource provider ContainerTerminationMetric test.
Date Fri, 18 Jan 2019 11:45:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69781/
-----------------------------------------------------------

(Updated Jan. 18, 2019, 12:45 p.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
-------

Addressed issues raised by Chun.


Bugs: MESOS-9130
    https://issues.apache.org/jira/browse/MESOS-9130


Repository: mesos


Description
-------

While we addressed one source of flakiness of this test in
`2117f671c450d7c74edc53078e8c0ed6035020aa` we introduced a new source of
flakiness (agents send more than the expected number of
`UpdateSlaveMessage`s since they failed a timeout in registration with
the master).

This patch ensures that the agent registers successfully before
continuing with the test.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp 164e93a3749d4d668e12de31641aecddddece384



Diff: https://reviews.apache.org/r/69781/diff/2/

Changes: https://reviews.apache.org/r/69781/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message