mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69792: Added an ostream operator for `Operation`.
Date Tue, 22 Jan 2019 22:46:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69792/#review212204
-----------------------------------------------------------




src/common/type_utils.cpp
Lines 782 (patched)
<https://reviews.apache.org/r/69792/#comment297894>

    Nit: Is there any reason not to use `operation.info().id()` here instead of `latestStatus.operation_id()`?
They should be equivalent, but it seems strange to look in the status instead of the operation
itself here, since they're both equally simple.


- Greg Mann


On Jan. 18, 2019, 10:59 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69792/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2019, 10:59 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
>     https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an ostream operator for `Operation`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 3926f491f41aee255ca13ed6a2731fbc88efb9a5 
>   src/common/type_utils.cpp df888efbdb99e07584e446079c337e7b9eb7cede 
> 
> 
> Diff: https://reviews.apache.org/r/69792/diff/1/
> 
> 
> Testing
> -------
> 
> Current tests still pass.
> 
> Manually looked at the logs generated by the changes in this change, and they look pretty
good.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message