From reviews-return-84733-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 17 12:04:13 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F6DA10813 for ; Thu, 17 Jan 2019 12:04:13 +0000 (UTC) Received: (qmail 37550 invoked by uid 500); 17 Jan 2019 12:04:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37520 invoked by uid 500); 17 Jan 2019 12:04:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37503 invoked by uid 99); 17 Jan 2019 12:04:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2019 12:04:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6045AD1420; Thu, 17 Jan 2019 12:04:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.902 X-Spam-Level: ** X-Spam-Status: No, score=2.902 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Nb1wCVKc8soG; Thu, 17 Jan 2019 12:04:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9995860E49; Thu, 17 Jan 2019 11:55:56 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EFD3FE0239; Thu, 17 Jan 2019 11:55:55 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DF15CC4038D; Thu, 17 Jan 2019 11:55:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5304738341880482169==" MIME-Version: 1.0 Subject: Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers. From: fei long To: Benno Evers Cc: Mesos Reviewbot , Mesos Reviewbot Windows , fei long , Joseph Wu , mesos Date: Thu, 17 Jan 2019 11:55:55 -0000 Message-ID: <20190117115555.40333.39170@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: fei long X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69735/ X-Sender: fei long References: <20190114085712.64748.24259@reviews-vm2.apache.org> In-Reply-To: <20190114085712.64748.24259@reviews-vm2.apache.org> Reply-To: fei long X-ReviewRequest-Repository: mesos --===============5304738341880482169== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 14, 2019, 8:57 a.m., Gilbert Song wrote: > > Is `MasterAPITest.OperationUpdatesUponAgentGone/1` failure releted to the change? I run "./bin/mesos-tests.sh --verbose --gtest_filter="*OperationUpdatesUponAgentGone*" --gtest_break_on_failure --gtest_repeat=100" locally and it passed. I believe it's caused by something else. - fei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211948 ----------------------------------------------------------- On Jan. 14, 2019, 3:34 a.m., fei long wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69735/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2019, 3:34 a.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9394 > https://issues.apache.org/jira/browse/MESOS-9394 > > > Repository: mesos > > > Description > ------- > > Fixed maintenance causes machines not in schedule rescinding offers. > > > Diffs > ----- > > src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4 > > > Diff: https://reviews.apache.org/r/69735/diff/1/ > > > Testing > ------- > > > Thanks, > > fei long > > --===============5304738341880482169==--