mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.
Date Tue, 05 Feb 2019 07:43:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69894/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.


Bugs: MESOS-9544
    https://issues.apache.org/jira/browse/MESOS-9544


Repository: mesos


Description
-------

`DESTROY_DISK` would bypass persistent volume cleanup and directly ask
the CSI plugin to delete the backed volume. Since the CSI spec does not
require the plugin to do data cleanup, to avoid data leakage, we require
that if there is persistent volume on the CSI volume, it should be
destroyed first.


Diffs
-----

  src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741 
  src/tests/master_validation_tests.cpp c00e8bb315c28bdf438da2089dd81f5e348982e5 


Diff: https://reviews.apache.org/r/69894/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message