mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69876: Removed operations from master state when an agent is downgraded.
Date Thu, 07 Feb 2019 22:56:39 GMT


> On Feb. 5, 2019, 12:28 a.m., Gastón Kleiman wrote:
> > src/tests/master_tests.cpp
> > Lines 9419 (patched)
> > <https://reviews.apache.org/r/69876/diff/1/?file=2123554#file2123554line9419>
> >
> >     We should consider making the agent not recover the operation status update
manager if it isn't started with the `AGENT_OPERATION_FEEDBACK` capability.
> 
> Gastón Kleiman wrote:
>     If we don't, we should not drop this message and make sure that the framework can
acknowledge the update, so that the agent stops resending it.

I created a ticket to track this work: https://issues.apache.org/jira/browse/MESOS-9561


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69876/#review212538
-----------------------------------------------------------


On Jan. 31, 2019, 11:08 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69876/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2019, 11:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9535
>     https://issues.apache.org/jira/browse/MESOS-9535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent is downgraded from one with the AGENT_OPERATION_FEEDBACK
> capability to one without this capability, the master needs to remove
> terminal-but-unACKed operations from its state which operate on agent
> default resources, since the downgraded agent will not resend status
> updates for these operations.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f74b7c280569e1c24e0940463bb28bd795d429d5 
>   src/tests/master_tests.cpp acc6096239e4992bdca084d88880d644ab4a2385 
> 
> 
> Diff: https://reviews.apache.org/r/69876/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*CleanupOperationsAfterAgentDowngrade*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message