mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 70656: Fix a bug where racing quota removal request could crash the master.
Date Thu, 16 May 2019 12:56:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70656/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9786
    https://issues.apache.org/jira/browse/MESOS-9786


Repository: mesos


Description
-------

Also added a test.


Diffs
-----

  src/master/quota_handler.cpp 5d449e6f027a69ccaa0ac3473ea4cf57441601f3 
  src/tests/master_quota_tests.cpp 66641f2d4e1dc7fd3d1da8d83dc4a45b447fc4bf 


Diff: https://reviews.apache.org/r/70656/diff/1/


Testing
-------

make check
Also added a dedicated test.

The test would crash the master without the fix. After applying the fix, the test runs continously
without failure.


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message