mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70660: Fix the XFS build for recent Fedora versions.
Date Fri, 17 May 2019 04:23:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70660/#review215313
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70660]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On May 17, 2019, 2:24 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70660/
> -----------------------------------------------------------
> 
> (Updated May 17, 2019, 2:24 a.m.)
> 
> 
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On Fedora 30, we need to include <xfs/xfs.h> to get the right
> types, since <xfs/xfs_types.h> is no longer self-contained. For
> earlier versions, it is still safe to include both headers if
> they are available, though <xfs/xfs_types.>h> may need to be
> obtained via the xfsprogs-qa-devel package.
> 
> 
> Diffs
> -----
> 
>   configure.ac b4bad5716986e2f7c132c6515179a65ccbfdaeac 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp db1829abbaac6113d39e71673403afe75b5ee738

> 
> 
> Diff: https://reviews.apache.org/r/70660/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedota 30)
> make (CentOS 6)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message