mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 70661: Added `CHECK_CONTAINS` and `CHECK_NOT_CONTAINS` macros.
Date Fri, 17 May 2019 06:46:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70661/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Meng Zhu.


Repository: mesos


Description
-------

Added a simple `CHECK_CONTAINS` and `CHECK_NOT_CONTAINS` to replace
checks of the form `CHECK(foo.contains(bar))`. These macros format
the value of the key in their failure message to assist debugging.


Diffs
-----

  3rdparty/stout/include/stout/check.hpp 7651150bb6cbe148af1e148658deff3d65ae4746 


Diff: https://reviews.apache.org/r/70661/diff/1/


Testing
-------

make check (Fedora 30)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message