mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Review Request 70668: Fixed the race between validating and applying FrameworkInfo updates.
Date Fri, 17 May 2019 15:07:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70668/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258 and MESOS-9763
    https://issues.apache.org/jira/browse/MESOS-7258
    https://issues.apache.org/jira/browse/MESOS-9763


Repository: mesos


Description
-------

This patch moves the FrameworkInfo update validation into the
continuation of the SUBSCRIBE calls (after authorization). This fixes
the race between two concurrent SUBSCRIBE calls attempting to change
principal (see MESOS-9763) and prevents the future changes of the update
validation from exacerbating this race.


Diffs
-----

  src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d 


Diff: https://reviews.apache.org/r/70668/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message