mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.
Date Fri, 17 May 2019 16:32:46 GMT


> On May 12, 2019, 5:44 a.m., Benjamin Mahler wrote:
> > src/tests/update_framework_tests.cpp
> > Lines 98 (patched)
> > <https://reviews.apache.org/r/70534/diff/4/?file=2143581#file2143581line98>
> >
> >     What does the presence of agent reservations matter to testing UPDATE_FRAMEWORK?

Indeed, reservations are not necessary for testing that allocator gets the update.

We can update from no roles to one role and check for an offer - I rewrote the test.


> On May 12, 2019, 5:44 a.m., Benjamin Mahler wrote:
> > src/tests/update_framework_tests.cpp
> > Lines 390-421 (patched)
> > <https://reviews.apache.org/r/70534/diff/4/?file=2143581#file2143581line390>
> >
> >     Is there no mock for this yet? How was the event streaming API tested without
it?
> >     
> >     How about pulling this out in front of this patch into its own header so that
we can review it on its own? It's independent and adds to the complexity of this review.

It was tested by explicitly reading out every event (example: https://github.com/apache/mesos/blob/91fa416bf0d6191bb1a5e1fa3c883e23c98e892c/src/tests/api_tests.cpp#L3396).
Surely, each time a new event type was introduced, one had to modify unrelated tests: https://reviews.apache.org/r/61262/diff/8#index_header

Moved this mock into https://reviews.apache.org/r/70671/


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70534/#review215206
-----------------------------------------------------------


On May 17, 2019, 3:19 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70534/
> -----------------------------------------------------------
> 
> (Updated May 17, 2019, 3:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for the V1 UPDATE_FRAMEWORK call.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5f97523fbe2d80733fbdcc7706f2761f5a071f9f 
>   src/tests/CMakeLists.txt e6b1d8a097246f0921467d7f778034d6754fcff6 
>   src/tests/master/update_framework_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70534/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message