mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70945: Added constructors with a list of suppressed roles to Java V0 bindings.
Date Mon, 01 Jul 2019 13:44:02 GMT


> On June 25, 2019, 7:30 p.m., Benjamin Mahler wrote:
> > src/java/src/org/apache/mesos/MesosSchedulerDriver.java
> > Lines 260-265 (patched)
> > <https://reviews.apache.org/r/70945/diff/1/?file=2152164#file2152164line260>
> >
> >     Why only this overload? What if the caller doesn't have a credential to pass?
E.g. `implicitAcknowledgements` was added to both credential and non-credential constructors.
> >     
> >     (we should really have a builder style api here)

Added a constructor with credential.

Regarding the builder interface... how do you estimate the risk that V0 frameworks will still
be around when one more parameter needed for authenticating or subscribing will be introduced
into Mesos? 6 constructors is alreay too much, 8 will be a nightmare.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70945/#review216127
-----------------------------------------------------------


On July 1, 2019, 1:38 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70945/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 1:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
>     https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added constructors with a list of suppressed roles to Java V0 bindings.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130

>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4

> 
> 
> Diff: https://reviews.apache.org/r/70945/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message