mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70985: Added `suppressOffers(roles)` to V0 Java bindings.
Date Tue, 02 Jul 2019 11:01:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70985/#review216305
-----------------------------------------------------------



Bad review!

Reviews applied: [70985, 70984, 70983, 70945, 70944, 70943, 70947, 70942, 70941, 70982, 70895,
70897, 70894]

Error:
2019-07-02 11:01:16 URL:https://reviews.apache.org/r/70941/diff/raw/ [3294/3294] -> "70941.patch"
[1]
error: patch failed: include/mesos/scheduler.hpp:293
error: include/mesos/scheduler.hpp: patch does not apply
error: patch failed: src/sched/sched.cpp:1436
error: src/sched/sched.cpp: patch does not apply

- Mesos Reviewbot


On July 1, 2019, 1:51 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70985/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 1:51 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
>     https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `suppressOffers(roles)` to V0 Java bindings.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130

>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4

>   src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f

> 
> 
> Diff: https://reviews.apache.org/r/70985/diff/1/
> 
> 
> Testing
> -------
> 
> Called this method from a modified example framework (WIP).
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message