mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70899: Refactored the agent's task-killing code.
Date Tue, 02 Jul 2019 22:52:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/#review216322
-----------------------------------------------------------




src/slave/slave.cpp
Lines 3673-3680 (original), 3673-3679 (patched)
<https://reviews.apache.org/r/70899/#comment303492>

    Due to splitting out the `killPendingTask`, this logic is now executed before the check
for `framework->state == Framework::TERMINATING`.  This means the agent will no longer
log that warning message (Ignoring kill task ...) for pending tasks only.
    
    Is this intentional?  (It probably isn't a big deal if we don't log this warning.)


- Joseph Wu


On July 1, 2019, 12:49 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70899/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 12:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch factors the code responsible for killing tasks
> out into two helper functions. This will facilitate the
> calling of this common code by the agent-draining handler.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70899/diff/4/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message