mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70903: Killed all tasks on the agent when draining.
Date Tue, 02 Jul 2019 23:44:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216330
-----------------------------------------------------------




src/slave/slave.cpp
Lines 1034 (patched)
<https://reviews.apache.org/r/70903/#comment303498>

    This could use some comment explaining why the `utils::copy` is needed.  I believe frameworks
will be removed while inside `kill()`, which calls `statusUpdate()`, which checks `framework->idle()`,
and then calls `removeFramework`.
    
    Normally, unless the modification to the copied list is very obvious, a comment is needed
to justify the copy.
    
    Similar with the other copies within this loop. (And the one `executor->launchedTasks`
that isn't copied.)


- Joseph Wu


On July 1, 2019, 12:57 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 12:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70903/diff/3/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message