mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70886: Override source address for executors.
Date Thu, 04 Jul 2019 20:33:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70886/#review216390
-----------------------------------------------------------



Bad review!

Reviews applied: [70886, 70993, 70933, 70797, 70992, 70991, 70921, 70795, 70749, 70883, 70884,
70810, 70748]

Error:
2019-07-04 20:33:43 URL:https://reviews.apache.org/r/70992/diff/raw/ [812/812] -> "70992.patch"
[1]
error: patch failed: CHANGELOG:27
error: CHANGELOG: patch does not apply

- Mesos Reviewbot


On June 19, 2019, 2:48 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70886/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 2:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jan-Philip Gehrcke, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore an executor's reported IP address and enforce the hostname
> "localhost" instead.
> 
> This is intended to enable TLS connections to executors running
> in bridge-mode or virtual-mode docker containers, which can not
> present a valid certificate containing their source IP which is
> dynamically generated and not known until the executor connects.
> 
> NOTE: This change is for illustration purposes only, and is not
> intended to be upstreamed.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70886/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message