mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 70887: Added `track`, `pendingFutures` functions for tracking pending futures. (WIP)
Date Thu, 11 Jul 2019 17:06:08 GMT


> On Июль 1, 2019, 12:35 д.п., Qian Zhang wrote:
> > src/slave/containerizer/mesos/future_track.hpp
> > Lines 85 (patched)
> > <https://reviews.apache.org/r/70887/diff/2/?file=2151423#file2151423line85>
> >
> >     Can we use `std::vector` instead?

The implementation relies on STL containers that do not invalidate iterators on container
modification. An iterator returned by the `pending.emplace` in the `addFuture` method is captured
by the future callbacks. This iterator references a corresponding item in the `pending` list,
which gets removed once the future is ready.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70887/#review216253
-----------------------------------------------------------


On Июнь 19, 2019, 2:49 п.п., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70887/
> -----------------------------------------------------------
> 
> (Updated Июнь 19, 2019, 2:49 п.п.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, James Peach, Meng Zhu, and Qian
Zhang.
> 
> 
> Bugs: MESOS-9837
>     https://issues.apache.org/jira/browse/MESOS-9837
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a mechanism for tracking of pending futures.
> This feature can be used to detect hanging operations, which might
> get stuck on a blocking operation or asynchronously. Both `track`
> and `pendingFutures` functions depend on `PendingFutureTracker`
> class, which is instantiated the first time they are accessed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/slave/containerizer/mesos/future_track.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70887/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message