mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70887: Added `PendingFutureTracker` class for tracking pending futures.
Date Mon, 15 Jul 2019 08:35:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70887/#review216603
-----------------------------------------------------------




src/Makefile.am
Lines 1070 (patched)
<https://reviews.apache.org/r/70887/#comment303808>

    Should we name it `future_tracker.hpp` to be consistent with the class in it (`PendingFutureTracker`)?



src/common/future_track.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/70887/#comment303812>

    s/__FUTURE_TRACK_HPP__/__FUTURE_TRACKER_HPP__/



src/common/future_track.hpp
Lines 34 (patched)
<https://reviews.apache.org/r/70887/#comment303811>

    I do not think we need this since this file has been moved to `src/common/`.



src/common/future_track.hpp
Lines 55-56 (patched)
<https://reviews.apache.org/r/70887/#comment303809>

    Suggest to merge these two lines into a single line.



src/common/future_track.hpp
Lines 90 (patched)
<https://reviews.apache.org/r/70887/#comment303810>

    I'd suggest to use `Owned` instead of raw pointer.


- Qian Zhang


On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70887/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 10:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, James Peach, Meng Zhu, and Qian
Zhang.
> 
> 
> Bugs: MESOS-9837
>     https://issues.apache.org/jira/browse/MESOS-9837
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a mechanism for tracking pending futures.
> This feature allows detection of hanging operations, which get
> stuck on a blocking operation or asynchronously. However, this
> feature does not provide any mechanism for tracking pending
> promises, because `Promise` objects might not be accessible in
> various cases. Thereby, we introduce a new class that can be
> used to track pending futures, so it might facilitate debugging
> of stuck issues.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/common/future_track.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70887/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message