mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 70887: Added `PendingFutureTracker` class for tracking pending futures.
Date Tue, 16 Jul 2019 16:41:34 GMT


> On Июль 16, 2019, 7:11 д.п., Gilbert Song wrote:
> > src/common/future_tracker.hpp
> > Lines 101-105 (patched)
> > <https://reviews.apache.org/r/70887/diff/4/?file=2154856#file2154856line101>
> >
> >     probably we want to add some comments to explain these parameters.
> >     
> >     Other than `name`, another para confuses me a bit is `component`.
> >     
> >     In next patch, we have `containerizer` as component and `isolator::method` as
name. How do we define component and name for the following case:
> >     ```
> >     mesos_containerizer->provisioner->docker_store->local_puller->pull()```
> 
> Qian Zhang wrote:
>     Do we really need both `name` and `component`? Can we just keep one? I think the
`name` like `linux/seccomp::prepare` already give us enough info, why do we need `containerizer`
as `component` here?

Note that there is one instance of `PendingFutureTracker` per agent. This single tracker can
be used to track pending operations besides the containerizer. Pending futures belonging to
different components may be exposed via different endpoints. `component` is just a way to
distinguish them from endpoint perspective.

> How do we define component and name for the following case:

It depends on which endpoint exposes which set of pending futures. E.g., if you want to expose
info about puller operations via the `/containerizer/debug` endpoint, then you need to specify
appropriate component (`COMPONENT_NAME_CONTAINERIZER`). In general, you may introduce a new
constant, e.g. `COMPONENT_NAME_DEFAULT`, which shall be used in all other cases.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70887/#review216641
-----------------------------------------------------------


On Июнь 19, 2019, 2:49 п.п., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70887/
> -----------------------------------------------------------
> 
> (Updated Июнь 19, 2019, 2:49 п.п.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, James Peach, Meng Zhu, and Qian
Zhang.
> 
> 
> Bugs: MESOS-9837
>     https://issues.apache.org/jira/browse/MESOS-9837
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a mechanism for tracking pending futures.
> This feature allows detection of hanging operations, which get
> stuck on a blocking operation or asynchronously. However, this
> feature does not provide any mechanism for tracking pending
> promises, because `Promise` objects might not be accessible in
> various cases. Thereby, we introduce a new class that can be
> used to track pending futures, so it might facilitate debugging
> of stuck issues.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/common/future_tracker.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70887/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message