mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71092: Added additional synchronization to a previously flaky test.
Date Wed, 17 Jul 2019 14:18:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71092/#review216690
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71092]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On July 17, 2019, 12:02 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71092/
> -----------------------------------------------------------
> 
> (Updated July 17, 2019, 12:02 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-9895
>     https://issues.apache.org/jira/browse/MESOS-9895
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test did not make sure that the agent's task status update manager
> had received a task status update acknowledgemtn before launching a
> subsequent task. The agent then, given its state, correctly rejected the
> task.
> 
> This patch adds additional synchronization so the agent has finished
> processing the task status update like expected.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1ed59ca5af69a6b53ceb8be035e608286299c2f1 
> 
> 
> Diff: https://reviews.apache.org/r/71092/diff/1/
> 
> 
> Testing
> -------
> 
> This test previously failed about 4% of the time in ~400 iterations (~20 failures) under
a lot of additional system stress. With this patch it did not fail once in 500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message