From reviews-return-88552-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 1 13:33:21 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 7098F199E5 for ; Mon, 1 Jul 2019 13:33:21 +0000 (UTC) Received: (qmail 63211 invoked by uid 500); 1 Jul 2019 13:33:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 63188 invoked by uid 500); 1 Jul 2019 13:33:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 63145 invoked by uid 99); 1 Jul 2019 13:33:20 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jul 2019 13:33:20 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0280CE0DDB; Mon, 1 Jul 2019 13:33:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DDDC0C4032D; Mon, 1 Jul 2019 13:33:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3024751514387544444==" MIME-Version: 1.0 Subject: Re: Review Request 70942: Added a test for 'reviveOffers(roles)'. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Mon, 01 Jul 2019 13:33:09 -0000 Message-ID: <20190701133309.59548.82608@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70942/ X-Sender: Andrei Sekretenko References: <20190625194426.12773.70074@reviews-vm2.apache.org> In-Reply-To: <20190625194426.12773.70074@reviews-vm2.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============3024751514387544444== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 25, 2019, 7:44 p.m., Benjamin Mahler wrote: > > src/tests/scheduler_driver_tests.cpp > > Lines 514-516 (patched) > > > > > > This seems unnecessary? Removed this `settle()`. It does nothing useful except for preventing a potential race between `EXPECT_CALL(resourceOffers, ...)` and the driver calling `resourceOffers()` (which is possible only if the offer filters / framework update are broken). And testing offer filters / framework update is not the purpose of this test. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70942/#review216130 ----------------------------------------------------------- On July 1, 2019, 1:32 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70942/ > ----------------------------------------------------------- > > (Updated July 1, 2019, 1:32 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9849 > https://issues.apache.org/jira/browse/MESOS-9849 > > > Repository: mesos > > > Description > ------- > > Added a test for 'reviveOffers(roles)'. > > > Diffs > ----- > > src/tests/scheduler_driver_tests.cpp 46af8d2c0fff15974b028521d1434e67bd9217da > > > Diff: https://reviews.apache.org/r/70942/diff/3/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="MesosSchedulerDriverTest*ReviveSingleRole*" --gtest_break_on_failure --gtest_repeat=1000` > > > Thanks, > > Andrei Sekretenko > > --===============3024751514387544444==--