From reviews-return-88635-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jul 3 19:42:16 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 417CD19A9F for ; Wed, 3 Jul 2019 19:42:16 +0000 (UTC) Received: (qmail 23812 invoked by uid 500); 3 Jul 2019 19:42:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23797 invoked by uid 500); 3 Jul 2019 19:42:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23775 invoked by uid 99); 3 Jul 2019 19:42:15 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jul 2019 19:42:15 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90885E0101; Wed, 3 Jul 2019 19:42:14 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7D29AC4027C; Wed, 3 Jul 2019 19:42:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0852460902288758713==" MIME-Version: 1.0 Subject: Re: Review Request 70980: Removed deactivation of already inactive roles on framework update. From: Benjamin Mahler To: Meng Zhu , Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 03 Jul 2019 19:42:14 -0000 Message-ID: <20190703194214.28798.61959@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70980/ X-Sender: Benjamin Mahler References: <20190629125608.54426.5056@reviews-vm2.apache.org> In-Reply-To: <20190629125608.54426.5056@reviews-vm2.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============0852460902288758713== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70980/#review216357 ----------------------------------------------------------- Did you want to discard this? - Benjamin Mahler On June 29, 2019, 12:56 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70980/ > ----------------------------------------------------------- > > (Updated June 29, 2019, 12:56 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9870 > https://issues.apache.org/jira/browse/MESOS-9870 > > > Repository: mesos > > > Description > ------- > > This is a refactoring of `updateFramework()` in the hierarchial > allocator which makes the symmetry between activating and > deactivating roles more visible. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp 26aad6778f12b99bb87c846788d6b6d60f743d8a > > > Diff: https://reviews.apache.org/r/70980/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > > --===============0852460902288758713==--