From reviews-return-88698-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 8 14:35:13 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 936BD196C1 for ; Mon, 8 Jul 2019 14:35:13 +0000 (UTC) Received: (qmail 95074 invoked by uid 500); 8 Jul 2019 14:35:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 95030 invoked by uid 500); 8 Jul 2019 14:35:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 95017 invoked by uid 99); 8 Jul 2019 14:35:12 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jul 2019 14:35:12 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2393EE00A6; Mon, 8 Jul 2019 14:35:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 07F3BC401D6; Mon, 8 Jul 2019 14:35:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0940420222107100711==" MIME-Version: 1.0 Subject: Re: Review Request 71024: Supported insecure registry when provisioning docker images. From: Mesos Reviewbot To: Mesos Reviewbot , fei long , mesos Date: Mon, 08 Jul 2019 14:35:12 -0000 Message-ID: <20190708143512.23452.61074@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71024/ X-Sender: Mesos Reviewbot References: <20190708142701.23453.32034@reviews-vm2.apache.org> In-Reply-To: <20190708142701.23453.32034@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============0940420222107100711== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71024/#review216417 ----------------------------------------------------------- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On July 8, 2019, 2:27 p.m., fei long wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71024/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 2:27 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-6183 > https://issues.apache.org/jira/browse/MESOS-6183 > > > Repository: mesos > > > Description > ------- > > Supported insecure registry when provisioning docker images. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp d013c9d71c39c09e600f181aba31b8037aa9226a > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885 > src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 > src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 > src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 > src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 > src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 > src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 > > > Diff: https://reviews.apache.org/r/71024/diff/1/ > > > Testing > ------- > > All testing cases passed. > > > Thanks, > > fei long > > --===============0940420222107100711==--