From reviews-return-88711-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 8 20:33:34 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id E374C194E2 for ; Mon, 8 Jul 2019 20:33:33 +0000 (UTC) Received: (qmail 59162 invoked by uid 500); 8 Jul 2019 20:33:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 59142 invoked by uid 500); 8 Jul 2019 20:33:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 59119 invoked by uid 99); 8 Jul 2019 20:33:33 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jul 2019 20:33:33 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3F6EAE00EA; Mon, 8 Jul 2019 20:33:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 206C8C408B5; Mon, 8 Jul 2019 20:33:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2311344149146541912==" MIME-Version: 1.0 Subject: Re: Review Request 71032: Added a test for /roles quota_consumption field. From: Mesos Reviewbot To: Meng Zhu , Andrei Sekretenko Cc: Mesos Reviewbot , Benjamin Mahler , mesos Date: Mon, 08 Jul 2019 20:33:32 -0000 Message-ID: <20190708203332.23452.13462@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71032/ X-Sender: Mesos Reviewbot References: <20190708180734.23452.37668@reviews-vm2.apache.org> In-Reply-To: <20190708180734.23452.37668@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============2311344149146541912== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71032/#review216424 ----------------------------------------------------------- Patch looks great! Reviews applied: [71031, 71027, 71028, 71029, 71030, 71032] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 8, 2019, 6:07 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71032/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 6:07 p.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9871 > https://issues.apache.org/jira/browse/MESOS-9871 > > > Repository: mesos > > > Description > ------- > > This ensures that the various edge different states of resources > are correctly handled, see test comment for more details. > > > Diffs > ----- > > src/tests/role_tests.cpp bf5b3cba59d38eee41ed222d14bc8c928fcf2a79 > > > Diff: https://reviews.apache.org/r/71032/diff/1/ > > > Testing > ------- > > Ran 1000 times in repetition. > > > Thanks, > > Benjamin Mahler > > --===============2311344149146541912==--