From reviews-return-88713-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 8 21:55:12 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 6843719752 for ; Mon, 8 Jul 2019 21:55:12 +0000 (UTC) Received: (qmail 62831 invoked by uid 500); 8 Jul 2019 21:55:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 62814 invoked by uid 500); 8 Jul 2019 21:55:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62797 invoked by uid 99); 8 Jul 2019 21:55:11 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jul 2019 21:55:11 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0FC0FE00EA; Mon, 8 Jul 2019 21:55:11 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E8DD9C401D6; Mon, 8 Jul 2019 21:55:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1817569233218615597==" MIME-Version: 1.0 Subject: Re: Review Request 70906: Fixed pid checkpointing for `TestContainerizer`. From: Gilbert Song To: Joseph Wu , Greg Mann Cc: Benjamin Bannier , mesos Date: Mon, 08 Jul 2019 21:55:10 -0000 Message-ID: <20190708215510.23452.93532@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70906/ X-Sender: Gilbert Song X-ReviewBoard-ShipIt: 1 References: <20190708212003.23453.34900@reviews-vm2.apache.org> In-Reply-To: <20190708212003.23453.34900@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============1817569233218615597== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70906/#review216426 ----------------------------------------------------------- Ship it! Ship It! - Gilbert Song On July 8, 2019, 2:20 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70906/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 2:20 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > In order for a `MockExecutor` to be able to reregister after agent > restart a persisted pid is required. This patch adds checkpointing of > the pid. > > > Diffs > ----- > > src/tests/containerizer.cpp fab7e81339f3b7b3fec2a4f6cb7e3a52df2607ed > > > Diff: https://reviews.apache.org/r/70906/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > > --===============1817569233218615597==--