From reviews-return-88716-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 8 22:15:05 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 478C4197DE for ; Mon, 8 Jul 2019 22:15:05 +0000 (UTC) Received: (qmail 84260 invoked by uid 500); 8 Jul 2019 22:15:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 84242 invoked by uid 500); 8 Jul 2019 22:15:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 84225 invoked by uid 99); 8 Jul 2019 22:15:04 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jul 2019 22:15:04 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B748CE2B9D; Mon, 8 Jul 2019 22:15:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5DBB7C40AFE; Mon, 8 Jul 2019 22:15:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2425190633937398277==" MIME-Version: 1.0 Subject: Re: Review Request 71027: Renamed Role::allocatedResources to Role::allocatedAndOfferedResources. From: Meng Zhu To: Meng Zhu , Andrei Sekretenko Cc: Benjamin Mahler , mesos Date: Mon, 08 Jul 2019 22:15:03 -0000 Message-ID: <20190708221503.23452.98283@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Meng Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71027/ X-Sender: Meng Zhu X-ReviewBoard-ShipIt: 1 References: <20190708174557.23453.44736@reviews-vm2.apache.org> In-Reply-To: <20190708174557.23453.44736@reviews-vm2.apache.org> Reply-To: Meng Zhu X-ReviewRequest-Repository: mesos --===============2425190633937398277== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71027/#review216427 ----------------------------------------------------------- Ship it! src/master/master.hpp Lines 2702-2716 (original), 2702-2716 (patched) Looking at the resource json writer, we should be able to just use resource quantities. The only obstacle seems to be the unfortunately named `_revocable`: https://github.com/apache/mesos/blob/master/src/common/http.cpp#L720 src/master/master.hpp Lines 2714-2715 (original), 2714-2715 (patched) we are adding ranges here? another reason to use quantities. - Meng Zhu On July 8, 2019, 10:45 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71027/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 10:45 a.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > This exposes allocated + offered, so it has been renamed accordingly. > > > Diffs > ----- > > src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c > src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 > src/master/readonly_handler.cpp 0d1e3dc19352863263c3e8992a63852c7f27225b > > > Diff: https://reviews.apache.org/r/71027/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > > --===============2425190633937398277==--